Skip to content

[25464] Implement payload release in move assignment#6454

Open
caicaiking wants to merge 4 commits into
eProsima:masterfrom
caicaiking:pr_2
Open

[25464] Implement payload release in move assignment#6454
caicaiking wants to merge 4 commits into
eProsima:masterfrom
caicaiking:pr_2

Conversation

@caicaiking

@caicaiking caicaiking commented Jun 24, 2026

Copy link
Copy Markdown

Description

Ensure payload is released when another one is moved into it.

@Mergifyio backport 3.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Yueshan <caicaiking@gmail.com>
@MiguelCompany MiguelCompany self-requested a review June 26, 2026 05:55
@MiguelCompany MiguelCompany modified the milestones: v3.6.2, v3.6.3 Jun 26, 2026
MiguelCompany
MiguelCompany previously approved these changes Jun 26, 2026

@MiguelCompany MiguelCompany left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany self-requested a review June 29, 2026 14:33
@MiguelCompany MiguelCompany changed the title Implement payload release in move assignment [25464] Implement payload release in move assignment Jun 29, 2026
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany June 29, 2026 14:42
MiguelCompany
MiguelCompany previously approved these changes Jun 29, 2026
@MiguelCompany

Copy link
Copy Markdown
Member

@caicaiking The tests are failing badly. I am not opposed to the changes, but you should build and run the tests locally before we can move forward.

Signed-off-by: Yueshan <caicaiking@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants